dnfnotify pkgset plugin implementation#61179
Closed
vzhestkov wants to merge 5 commits intosaltstack:masterfrom
Closed
dnfnotify pkgset plugin implementation#61179vzhestkov wants to merge 5 commits intosaltstack:masterfrom
vzhestkov wants to merge 5 commits intosaltstack:masterfrom
Conversation
dhiltonp
requested review from
a team and
twangboy
and removed request for
a team and
dhiltonp
Contributor
|
@vzhestkov This one needs a changelog and tests. |
twangboy
previously approved these changes
May 2, 2022
vzhestkov
force-pushed
the
dnfnotify-plugin
branch
from
970e2d7 to
234bfb9
Compare
Contributor
Author
|
@garethgreenaway I added the changelog entry, but there is no way to add proper test for it as the code is actually invoked with the platform python used by DNF, there are no tests in this section of the code required for some specific cases. |
Contributor
|
Closing this due to inactivity. Anyone should feel free to re-open it if they want to see it through to the end in one release cycle. |
dwoz
added
help-wanted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements notification plugin for pkgset beacon for DNF package manager.
Yum notification plugin is not working with DNF as it's not invoking it.