Skip to content

add metadata_gce grain to handle googles new style of metadata server, which is not ec2 compat#61190

Merged
garethgreenaway merged 9 commits intosaltstack:masterfrom
whytewolf:52332
Feb 8, 2022
Merged

add metadata_gce grain to handle googles new style of metadata server, which is not ec2 compat#61190
garethgreenaway merged 9 commits intosaltstack:masterfrom
whytewolf:52332

Conversation

@whytewolf
Copy link
Collaborator

@whytewolf whytewolf commented Nov 5, 2021

What does this PR do?

Adds a new grain module to handle metadata for gce. since google has created their own standard for metadata servers, that is not ec2 compatible.

What issues does this PR fix or reference?

Fixes: #52332

Previous Behavior

No grains created for meta data information

New Behavior

New grains created that follow the layout of googles metadata

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

No

Thomas Phipps and others added 4 commits October 28, 2021 20:29
@whytewolf whytewolf requested a review from a team as a code owner November 5, 2021 20:01
@whytewolf whytewolf requested review from dhiltonp and removed request for a team November 5, 2021 20:01
dhiltonp
dhiltonp previously approved these changes Nov 5, 2021
@github-actions
Copy link

github-actions bot commented Nov 5, 2021

Hi! I'm your friendly PR bot!

You might be wondering what I'm doing commenting here on your PR.

Yes, as a matter of fact, I am...

I'm just here to help us improve the documentation. I can't respond to
questions or anything, but what I can do, I do well!

Okay... so what do you do?

I detect modules that are missing docstrings or "CLI Example" on existing docstrings!
When I was created we had a lot of these. The documentation for these
modules need some love and attention to make Salt better for our users.

So what does that have to do with my PR?

I noticed that in this PR there are some files changed that have some of these
issues. So I'm leaving this comment to let you know your options.

Okay, what are they?

Well, my favorite, is that since you were making changes here I'm hoping that
you would be the most familiar with this module and be able to add some other
examples or fix any of the reported issues.

If I can, then what?

Well, you can either add them to this PR or add them to another PR. Either way is fine!

Well... what if I can't, or don't want to?

That's also fine! We appreciate all contributions to the Salt Project. If you
can't add those other examples, either because you're too busy, or unfamiliar,
or you just aren't interested, we still appreciate the contributions that
you've made already.

Whatever approach you decide to take, just drop a comment here letting us know!

Detected Issues (click me)
[INFO] Initializing environment for https://github.com/saltstack/pip-tools-compile-impersonate.
[INFO] Initializing environment for https://github.com/asottile/pyupgrade.
[INFO] Initializing environment for https://github.com/saltstack/pre-commit-remove-import-headers.
[INFO] Initializing environment for https://github.com/s0undt3ch/salt-rewrite.
[INFO] Initializing environment for https://github.com/timothycrosley/isort.
[INFO] Initializing environment for https://github.com/timothycrosley/isort:toml.
[INFO] Initializing environment for https://github.com/psf/black.
[INFO] Initializing environment for https://github.com/asottile/blacken-docs.
[INFO] Initializing environment for https://github.com/asottile/blacken-docs:black==21.7b0.
[INFO] Initializing environment for https://github.com/PyCQA/bandit.
[INFO] Initializing environment for https://github.com/saltstack/invoke-pre-commit.
[INFO] Initializing environment for https://github.com/saltstack/invoke-pre-commit:blessings,distro,jinja2,msgpack,pyyaml.
[INFO] Initializing environment for https://github.com/saltstack/mirrors-nox.
[INFO] Initializing environment for https://github.com/saltstack/mirrors-nox:pip>=20.2.4,<21.2,setuptools<58.0.
[INFO] Installing environment for https://github.com/saltstack/invoke-pre-commit.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Check Known Missing Docstrings.......................(no files to check)Skipped
- hook id: invoke

Thanks again!

@garethgreenaway garethgreenaway merged commit f62de89 into saltstack:master Feb 8, 2022
@whytewolf whytewolf deleted the 52332 branch September 17, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Metadata Server Grains (metadata_server_grains) doesn't work in Google anymore

3 participants