Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle ctrl-c gracefully #61363

Merged
merged 7 commits into from
Feb 15, 2022
Merged

Handle ctrl-c gracefully #61363

merged 7 commits into from
Feb 15, 2022

Conversation

MKLeb
Copy link
Contributor

@MKLeb MKLeb commented Dec 14, 2021

What does this PR do?

Attempts to solve the mystery of non-graceful exits after a ctrl-c

What issues does this PR fix or reference?

Fixes: #60242

Previous Behavior

Exception ignored in: <generator object _read at 0x7f3fc4b17150> Traceback (most recent call last): File "/usr/lib/python3.6/site-packages/salt/transport/ipc.py", line 702, in _read TypeError: catching classes that do not inherit from BaseException is not allowed

New Behavior

No error thrown, clean exit

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@MKLeb MKLeb marked this pull request as ready for review January 3, 2022 17:22
@MKLeb MKLeb requested a review from a team as a code owner January 3, 2022 17:22
@MKLeb MKLeb requested review from twangboy, dwoz and s0undt3ch and removed request for a team and twangboy January 3, 2022 17:22
@MKLeb MKLeb linked an issue Jan 18, 2022 that may be closed by this pull request
@MKLeb MKLeb changed the title [WIP] Handle ctrl-c gracefully Handle ctrl-c gracefully Jan 18, 2022
@Ch3LL Ch3LL added the Phosphorus v3005.0 Release code name and version label Feb 1, 2022
@Ch3LL
Copy link
Contributor

Ch3LL commented Feb 4, 2022

ping @dwoz and @s0undt3ch can you review this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Phosphorus v3005.0 Release code name and version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Graceful exit throws an exception
3 participants