Merged
Conversation
Contributor
|
ping @dwoz and @s0undt3ch can you review this PR? |
s0undt3ch
approved these changes
Feb 7, 2022
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Attempts to solve the mystery of non-graceful exits after a ctrl-c
What issues does this PR fix or reference?
Fixes: #60242
Previous Behavior
Exception ignored in: <generator object _read at 0x7f3fc4b17150> Traceback (most recent call last): File "/usr/lib/python3.6/site-packages/salt/transport/ipc.py", line 702, in _read TypeError: catching classes that do not inherit from BaseException is not allowedNew Behavior
No error thrown, clean exit
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes