Handle new MariaDB SLAVE MONITOR grant #61382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sblaisot
force-pushed
the
update_mysql_grants
branch
from
2d88c59 to
72ffb95
Compare
|
@waynew any news on this PR? |
waynew
approved these changes
Jan 10, 2022
There was a problem hiding this comment.
Confirmed that SLAVE MONITOR is an available grant for mariadb.
Also checked the code and it looks like for other privs it's just a pre-validation, and the database itself actually has to support the grant.
👍 Looks good.
garethgreenaway
approved these changes
Jan 10, 2022
MKLeb
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Handle new MariaDB SLAVE MONITOR grant
What issues does this PR fix or reference?
Fixes: #61331
Previous Behavior
State mysql_grants.present fail when setting MariaDB 10.5+
SLAVE MONITORgrantNew Behavior
SLAVE MONITORgrant is appliedMerge requirements satisfied?
Commits signed with GPG?
No