Use "net" instead of "sc" to restart minion service - #61383
Merged
Conversation
Contributor
Author
|
@Ch3LL Added changelog |
Ch3LL
approved these changes
Jan 5, 2022
garethgreenaway
approved these changes
Jan 13, 2022
MKLeb
approved these changes
Jan 13, 2022
waynew
approved these changes
Jan 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Uses
netinstead ofscto restart the salt-minion service on Windows. Thenetcommand will not return until it completes, where thesccommand just fires thestoporstartand returns. That's why there was a 5 second sleep in between thestopandstartcommands. Sometimes the stop command takes longer than 5 seconds and the start command then fails because the service is still shutting down. Usingnetavoids this race condition and removes the need for the sleep command.What issues does this PR fix or reference?
Fixes: https://jira.eng.vmware.com/browse/VRAE-8756
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes