-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load Salt Cloud Hetzner Module Config from Usual Sources #61400
Conversation
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
I don't understand why the bot still mentions missing docstrings, did I not fix them? |
2034cc7
to
12db232
Compare
12db232
to
a419eeb
Compare
Hey @dwoz, this is ready for review. As mentioned, I don't quite understand why the PR Bot is complaining. Some pipelines seem to fail while trying to check out the code, so I assume it shouldn't concern me. If there is anything, please let me know! |
Maybe @Ch3LL could help me with this one? |
c3d22fc
to
dece711
Compare
966757a
to
b7b56a0
Compare
b7b56a0
to
16b48ec
Compare
Hi! I'm your friendly PR bot!You might be wondering what I'm doing commenting here on your PR. Yes, as a matter of fact, I am... I'm just here to help us improve the documentation. I can't respond to Okay... so what do you do? I detect modules that are missing docstrings or "CLI Example" on existing docstrings! So what does that have to do with my PR? I noticed that in this PR there are some files changed that have some of these Okay, what are they? Well, my favorite, is that since you were making changes here I'm hoping that If I can, then what? Well, you can either add them to this PR or add them to another PR. Either way is fine! Well... what if I can't, or don't want to? That's also fine! We appreciate all contributions to the Salt Project. If you Whatever approach you decide to take, just drop a comment here letting us know! Detected Issues (click me)Check Known Missing Docstrings...........................................Failed - hook id: invoke - duration: 1.72s - exit code: 1 Thanks again! |
Congratulations on your first PR being merged! 🎉 |
What does this PR do?
Fix config loading behaviour
What issues does this PR fix or reference?
Fixes: #61399
Previous Behavior
Config values were only taken from the current context, as available in
vm_
New Behavior
Search and return a setting in a known order:
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.