Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ability for scheduler module to work in offline mode #61423

Merged
merged 10 commits into from
Jan 19, 2022
Merged

Adding ability for scheduler module to work in offline mode #61423

merged 10 commits into from
Jan 19, 2022

Conversation

garethgreenaway
Copy link
Contributor

@garethgreenaway garethgreenaway commented Jan 6, 2022 •
edited
Loading

What does this PR do?

Adding the ability to add, delete, purge, and modify Salt scheduler jobs when the Salt minion is not running.

What issues does this PR fix or reference?

Fixes: #61324, #54846

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@garethgreenaway garethgreenaway requested a review from a team as a code owner January 6, 2022 00:15
@garethgreenaway garethgreenaway requested review from Ch3LL and removed request for a team January 6, 2022 00:15
@garethgreenaway garethgreenaway added the Phosphorus v3005.0 Release code name and version label Jan 6, 2022
@garethgreenaway garethgreenaway changed the title Adding ability for scheudler module to work in offline mode Adding ability for scheduler module to work in offline mode Jan 6, 2022
Ch3LL
Ch3LL suggested changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@Ch3LL Ch3LL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add documention for the new offline feature in each function's doc string?

changelog/61324.changed Outdated Show resolved Hide resolved
salt/modules/schedule.py Show resolved Hide resolved
Ch3LL
Ch3LL suggested changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@Ch3LL Ch3LL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing the changelog anymore

Ch3LL
Ch3LL previously approved these changes Jan 12, 2022
View reviewed changes
@Ch3LL Ch3LL merged commit 89e089e into saltstack:master Jan 19, 2022
@vzhestkov vzhestkov mentioned this pull request Aug 30, 2022
Merged
3 tasks
@garethgreenaway garethgreenaway mentioned this pull request Aug 28, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ch3LL Ch3LL Ch3LL approved these changes

Assignees
No one assigned
Labels
Phosphorus v3005.0 Release code name and version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] schedule state/module not working without minion running
2 participants
@garethgreenaway @Ch3LL