Ensure a sensible timeout for pgsql commands#61433
Conversation
The psql command has no default timeout, so if the server is not responding or if some lock cannot be obtained, we will be waiting forever. Introduce a default timeout of 60s for all psql commands.
|
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
dmurphy18
added
needs-testcase
|
@edevil Have you been able to look at implementing @dmurphy18 's suggestion? |
|
Hey @MKLeb. Sorry but no, I've been a bit busy. |
twangboy
left a comment
twangboy
left a comment
There was a problem hiding this comment.
This needs a test and a changelog
Ch3LL
removed
needs-testcase
|
Congratulations on your first PR being merged! 🎉 |
5 participants
The psql command has no default timeout, so if the server is not
responding or if some lock cannot be obtained, we will be waiting
forever.
What does this PR do?
Introduce a default timeout of 60s for all psql commands.
Previous Behavior
Module would wait forever for commands to return.
New Behavior
Module will wait at most 60s for psql command to complete.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.