Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --allow-downgrades capability for apt upgrade #61469

Merged

Conversation

jakelyz
Copy link
Contributor

@jakelyz jakelyz commented Jan 17, 2022

What does this PR do?

Adds the ability to specify --allow-downgrades when calling upgrade with apt

What issues does this PR fix or reference?

Fixes: #52977

Previous Behavior

It was not possible to pass --allow-downgrades to apt, when using pkg.upgrade

New Behavior

The flag --allow-downgrades is able to be passed to apt when using pkg.upgrade

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@jakelyz jakelyz requested a review from a team as a code owner January 17, 2022 06:43
@jakelyz jakelyz requested review from krionbsd and removed request for a team January 17, 2022 06:43
@welcome
Copy link

welcome bot commented Jan 17, 2022

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

krionbsd
krionbsd previously approved these changes Jan 17, 2022
@@ -1226,6 +1226,9 @@ def upgrade(refresh=True, dist_upgrade=False, **kwargs):

.. versionadded:: 2015.8.0

allow_downgrades
Allow apt to downgrade packages without a prompt.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a .. versionadded:: 3005 for this new arg?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in f517f10

@github-actions
Copy link

Hi! I'm your friendly PR bot!

You might be wondering what I'm doing commenting here on your PR.

Yes, as a matter of fact, I am...

I'm just here to help us improve the documentation. I can't respond to
questions or anything, but what I can do, I do well!

Okay... so what do you do?

I detect modules that are missing docstrings or "CLI Example" on existing docstrings!
When I was created we had a lot of these. The documentation for these
modules need some love and attention to make Salt better for our users.

So what does that have to do with my PR?

I noticed that in this PR there are some files changed that have some of these
issues. So I'm leaving this comment to let you know your options.

Okay, what are they?

Well, my favorite, is that since you were making changes here I'm hoping that
you would be the most familiar with this module and be able to add some other
examples or fix any of the reported issues.

If I can, then what?

Well, you can either add them to this PR or add them to another PR. Either way is fine!

Well... what if I can't, or don't want to?

That's also fine! We appreciate all contributions to the Salt Project. If you
can't add those other examples, either because you're too busy, or unfamiliar,
or you just aren't interested, we still appreciate the contributions that
you've made already.

Whatever approach you decide to take, just drop a comment here letting us know!

Detected Issues (click me)
Check Known Missing Docstrings...........................................Failed
- hook id: invoke
- duration: 1.39s
- exit code: 1

The function 'expand_repo_def' on 'salt/modules/aptpkg.py' does not have a 'CLI Example:' in it's docstring
Found 1 errors


Thanks again!

@jakelyz jakelyz requested a review from Ch3LL January 28, 2022 03:24
@Ch3LL Ch3LL merged commit 6bf44a0 into saltstack:master Feb 16, 2022
@welcome
Copy link

welcome bot commented Feb 16, 2022

Congratulations on your first PR being merged! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkg.upgrade does not handle --allow-downgrades for apt dist-upgrade
3 participants