Skip to content

Fix multiple LGPO issues#61528

Merged
garethgreenaway merged 4 commits into
saltstack:masterfrom
twangboy:fix_61510
Feb 8, 2022
Merged

Fix multiple LGPO issues#61528
garethgreenaway merged 4 commits into
saltstack:masterfrom
twangboy:fix_61510

Conversation

@twangboy

@twangboy twangboy commented Jan 27, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes two issues with the LGPO module
#61198 - A problem with name collisions. Fixed by case-sensitive searching
#54301 - An incorrect key name in the dictionary of policies

What issues does this PR fix or reference?

Fixes: #61198
Fixes: #54301
https://jira.eng.vmware.com/browse/VRAE-9281

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@twangboy
twangboy requested a review from a team as a code owner January 27, 2022 01:08
@twangboy
twangboy requested review from krionbsd and removed request for a team January 27, 2022 01:08
@twangboy twangboy changed the title Fix 61510 Fix multiple LGPO issues Jan 27, 2022
@twangboy
twangboy force-pushed the fix_61510 branch 2 times, most recently from 52190be to d77c25e Compare January 27, 2022 01:28
krionbsd
krionbsd previously approved these changes Jan 27, 2022
Comment thread salt/modules/win_lgpo.py Outdated
@Ch3LL Ch3LL added the Phosphorus v3005.0 Release code name and version label Jan 27, 2022
Fall back to non case sensitive names if not found
Add notes about Basic and Advanced Auditing
Advanced Auditing always takes precedence over Basic Auditing
You will be able to set Basic Auditing if Advanced Auditing is
or ever has been set. You have to delete the two audit.csv files
in order to set Basic Audit policies.
Comment thread salt/modules/win_lgpo.py
@garethgreenaway
garethgreenaway merged commit a4d40e0 into saltstack:master Feb 8, 2022
@twangboy
twangboy deleted the fix_61510 branch March 23, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Phosphorus v3005.0 Release code name and version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] lgpo.set state module fails to set 'Audit Directory Service Access' win_lgpo module cannot configure SceNoApplyLegacyAuditPolicy correctly

5 participants