Set default transport and port settings for Napalm NXOS, if not set#61556
Set default transport and port settings for Napalm NXOS, if not set#61556dmurphy18 merged 4 commits intosaltstack:masterfrom
Conversation
65a3aa0 to
ea476cb
Compare
|
re-run all |
f6c6ba5 to
90a85f6
Compare
|
The GitHub Actions Doc bot needs to be adjusted, since needs to allow for 'Usage example' present to stop the 'CLI Example' from generating an email. Both have warning stating 'This function is not suitable for CLI usage' in the doc string, which is what the bot is complaining about Bot is correct see #61566 for tech debt here |
|
re-run freebsd |
|
re-run centos-8 |
|
re-run centos |
|
re-run centosstream-8 |
6160153 to
32ea375
Compare
|
re-run all |
|
re-run freebsd |
Hi! I'm your friendly PR bot!You might be wondering what I'm doing commenting here on your PR. Yes, as a matter of fact, I am... I'm just here to help us improve the documentation. I can't respond to Okay... so what do you do? I detect modules that are missing docstrings or "CLI Example" on existing docstrings! So what does that have to do with my PR? I noticed that in this PR there are some files changed that have some of these Okay, what are they? Well, my favorite, is that since you were making changes here I'm hoping that If I can, then what? Well, you can either add them to this PR or add them to another PR. Either way is fine! Well... what if I can't, or don't want to? That's also fine! We appreciate all contributions to the Salt Project. If you Whatever approach you decide to take, just drop a comment here letting us know! Detected Issues (click me)Check Known Missing Docstrings...........................................Failed - hook id: invoke - duration: 1.57s - exit code: 1 Thanks again! |
What does this PR do?
Sets the default transport and port values for Napalm NXOS if they are not set. Napalm itself does this, but Salt is not recognizing these defaults values correctly and setting None, without an appropriate default value.
What issues does this PR fix or reference?
Fixes: #59448
Previous Behavior
Would cause a traceback when attempting to use the url 'None://a.b.c.d' rather than 'https' or 'http'.
New Behavior
Correctly now sets a default transport of 'https' and appropriate port 443.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.