Allow cp functions to derive saltenv from config#61564
Merged
garethgreenaway merged 1 commit intoFeb 8, 2022
Merged
Conversation
Contributor
Author
|
re-run pr-centos-8-x86_64-py3-pytest |
1352476 to
a94f360
Compare
Contributor
Author
|
@MKLeb can you take a look and see if this is a reasonable approach? Thanks! |
MKLeb
approved these changes
Feb 8, 2022
garethgreenaway
approved these changes
Feb 8, 2022
This was referenced Aug 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR allows the
cpmodule functions to derivesaltenvfrom config if not explicitly set as a keyword argument to the function. See issue for details.What issues does this PR fix or reference?
Fixes: #61562
Previous Behavior
On minions with a
saltenvset:The
cpfunctions would not detect thatsaltenvand default to "base":# returns files from the base env (if configured on the master) salt-call cp.list_masterThis often leads to user confusion or surprise because they expect the minion to be "in" a given environment.
New Behavior
The
cpfunctions will now detect thesaltenvfrom the configuration files and use that unless explicitly set:Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.