Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes cmdmod ignoreing saltenv set in configfile. #61598

Merged
merged 5 commits into from
Feb 8, 2022

Conversation

whytewolf
Copy link
Collaborator

What does this PR do?

bug fix for cmdmod not respecting saltenv set in config file.

What issues does this PR fix or reference?

Fixes: #61507

Previous Behavior

cmdmod ignores saltenv when it is set in the config file.

New Behavior

now it will pull the relevant data when it needs to.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

No

@whytewolf whytewolf requested a review from a team as a code owner February 7, 2022 22:56
@whytewolf whytewolf requested review from dwoz and removed request for a team February 7, 2022 22:56
@whytewolf whytewolf changed the title fixes cmdmod ignoreing saltenv set in configfile. fixes cmdmod ignoreing saltenv set in configfile. - wip Feb 8, 2022
@whytewolf
Copy link
Collaborator Author

well that didn't go as expected ... back to the drawing board

@whytewolf whytewolf marked this pull request as draft February 8, 2022 00:06
@whytewolf whytewolf changed the title fixes cmdmod ignoreing saltenv set in configfile. - wip fixes cmdmod ignoreing saltenv set in configfile. Feb 8, 2022
@whytewolf whytewolf marked this pull request as ready for review February 8, 2022 08:34
@garethgreenaway garethgreenaway merged commit 0472b0c into saltstack:master Feb 8, 2022
@whytewolf whytewolf deleted the 61507 branch September 17, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] cmdmod not respecting saltenv config option.
2 participants