The ProcessManager now starts instances of our custom Process class.#61603
Merged
Conversation
s0undt3ch
marked this pull request as ready for review
February 9, 2022 05:30
s0undt3ch
force-pushed
the
features/mac-pr-parts
branch
from
February 9, 2022 06:19
c1699eb to
a439d36
Compare
Contributor
Author
|
re-run full all |
s0undt3ch
force-pushed
the
features/mac-pr-parts
branch
from
February 9, 2022 17:46
a439d36 to
7ae2f7f
Compare
… class. Previously it was starting instances of ``multiprocessing.Process`` which required specific logic to decide if the ``log_queue`` and ``log_queue_level`` needed to be injected into ``**kwargs``
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
…assmethod`` Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch
force-pushed
the
features/mac-pr-parts
branch
from
February 10, 2022 06:56
7ae2f7f to
39bf0c9
Compare
twangboy
approved these changes
Feb 10, 2022
Ch3LL
approved these changes
Feb 10, 2022
dwoz
approved these changes
Feb 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Previously it was starting instances of
multiprocessing.Processwhich required specific logic to decide if thelog_queueandlog_queue_levelneeded to be injected into**kwargs