Simplify Logging#61629
Merged
Merged
Conversation
s0undt3ch
force-pushed
the
features/simplify-logging
branch
from
9b08d4b to
4b3a3cc
Compare
s0undt3ch
force-pushed
the
features/simplify-logging
branch
from
4b3a3cc to
a002271
Compare
s0undt3ch
force-pushed
the
features/simplify-logging
branch
5 times, most recently
from
f00b307 to
f60a8db
Compare
Contributor
Author
|
re-run all |
s0undt3ch
force-pushed
the
features/simplify-logging
branch
6 times, most recently
from
9e13e2e to
24b2f31
Compare
s0undt3ch
force-pushed
the
features/simplify-logging
branch
13 times, most recently
from
43edb80 to
61fac4d
Compare
s0undt3ch
force-pushed
the
features/simplify-logging
branch
from
271332b to
5a89367
Compare
Contributor
Author
|
re-run full all |
waynew
suggested changes
Apr 6, 2022
waynew
left a comment
waynew
left a comment
Contributor
There was a problem hiding this comment.
Just one thing that I think was missed with the last updates.
Otherwise, I didn't catch anything else that needs to be addressed 👍
Contributor
There was a problem hiding this comment.
Did you mean to resolve this? doesn't look like it changed 😅
Contributor
Author
|
re-run full all |
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
It also handles multiprocessing logging.
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
…kage Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
…ons. Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
When calculating the maximum logger name length, make sure it's not longer than 80 chars. Messages which need more that 80 chars will use them and be properly formatted, but not ALL log messages.
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Because `salt.engines.Engine` actually catches all exceptions. Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Contributor
Author
|
re-run full all |
waynew
approved these changes
Apr 11, 2022
twangboy
approved these changes
Apr 11, 2022
Ch3LL
approved these changes
Apr 12, 2022
Contributor
Author
|
/cc @dhiltonp. Thank You for the investigation work! |
6 tasks
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See title