Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unblock Deltaproxy startup when controlled proxy minions fail #61665

Conversation

garethgreenaway
Copy link
Contributor

What does this PR do?

wrap the call to the proxy init functions in a try except, so we are able to continue with the rest in case one has an issue.

What issues does this PR fix or reference?

Fixes: #61377

Previous Behavior

When starting up if one of the controlled proxy minions threw an exception during it's initialization, eg. a failed SSH connection, then the deltaproxy would continue trying to run the initialization fir tat proxy minion.

New Behavior

Wrap the call to the individual proxy initialization functions in a try...except, catching the exception, logging n error and moving onto the next proxy minion.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

…able to continue with the rest in case one has an issue.
@garethgreenaway garethgreenaway requested a review from a team as a code owner February 18, 2022 00:48
@garethgreenaway garethgreenaway requested review from waynew and removed request for a team February 18, 2022 00:48
salt/metaproxy/deltaproxy.py Outdated Show resolved Hide resolved
tests/pytests/integration/cli/test_salt_deltaproxy.py Outdated Show resolved Hide resolved
tests/pytests/integration/cli/test_salt_deltaproxy.py Outdated Show resolved Hide resolved
tests/pytests/integration/cli/test_salt_deltaproxy.py Outdated Show resolved Hide resolved
tests/pytests/integration/cli/test_salt_deltaproxy.py Outdated Show resolved Hide resolved
tests/pytests/integration/cli/test_salt_deltaproxy.py Outdated Show resolved Hide resolved
tests/pytests/integration/cli/test_salt_deltaproxy.py Outdated Show resolved Hide resolved
tests/pytests/integration/cli/test_salt_deltaproxy.py Outdated Show resolved Hide resolved
@Ch3LL Ch3LL added the Phosphorus v3005.0 Release code name and version label Feb 23, 2022
@Ch3LL Ch3LL merged commit 93493a1 into saltstack:master Feb 24, 2022
@garethgreenaway garethgreenaway changed the title Don't block startup when controlled proxy minions fail. Unblock Deltaproxy startup when controlled proxy minions fail Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Phosphorus v3005.0 Release code name and version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Deltaproxy should skip failed sub proxy devices
3 participants