Unblock Deltaproxy startup when controlled proxy minions fail#61665
Merged
Ch3LL merged 7 commits intoFeb 24, 2022
Merged
Conversation
…able to continue with the rest in case one has an issue.
…roxy minion to simulate an exception handling in the init function.
s0undt3ch
suggested changes
Feb 20, 2022
s0undt3ch
suggested changes
Feb 20, 2022
s0undt3ch
approved these changes
Feb 21, 2022
Ch3LL
approved these changes
Feb 23, 2022
garethgreenaway
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
wrap the call to the proxy init functions in a try except, so we are able to continue with the rest in case one has an issue.
What issues does this PR fix or reference?
Fixes: #61377
Previous Behavior
When starting up if one of the controlled proxy minions threw an exception during it's initialization, eg. a failed SSH connection, then the deltaproxy would continue trying to run the initialization fir tat proxy minion.
New Behavior
Wrap the call to the individual proxy initialization functions in a try...except, catching the exception, logging n error and moving onto the next proxy minion.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.