Skip to content

Remove telnet_port,serial_type,console in salt/modules/virt.py#61705

Merged
Ch3LL merged 1 commit intosaltstack:masterfrom
Ch3LL:rem_args_virt
Feb 24, 2022
Merged

Remove telnet_port,serial_type,console in salt/modules/virt.py#61705
Ch3LL merged 1 commit intosaltstack:masterfrom
Ch3LL:rem_args_virt

Conversation

@Ch3LL
Copy link
Contributor

@Ch3LL Ch3LL commented Feb 23, 2022

What does this PR do?

Remove telnet_port,serial_type,console in salt/modules/virt.py

What issues does this PR fix or reference?

Fixes: #61693

@Ch3LL Ch3LL requested a review from a team as a code owner February 23, 2022 17:49
@Ch3LL Ch3LL requested review from dwoz and removed request for a team February 23, 2022 17:49
@github-actions
Copy link

Hi! I'm your friendly PR bot!

You might be wondering what I'm doing commenting here on your PR.

Yes, as a matter of fact, I am...

I'm just here to help us improve the documentation. I can't respond to
questions or anything, but what I can do, I do well!

Okay... so what do you do?

I detect modules that are missing docstrings or "CLI Example" on existing docstrings!
When I was created we had a lot of these. The documentation for these
modules need some love and attention to make Salt better for our users.

So what does that have to do with my PR?

I noticed that in this PR there are some files changed that have some of these
issues. So I'm leaving this comment to let you know your options.

Okay, what are they?

Well, my favorite, is that since you were making changes here I'm hoping that
you would be the most familiar with this module and be able to add some other
examples or fix any of the reported issues.

If I can, then what?

Well, you can either add them to this PR or add them to another PR. Either way is fine!

Well... what if I can't, or don't want to?

That's also fine! We appreciate all contributions to the Salt Project. If you
can't add those other examples, either because you're too busy, or unfamiliar,
or you just aren't interested, we still appreciate the contributions that
you've made already.

Whatever approach you decide to take, just drop a comment here letting us know!

Detected Issues (click me)
Check Known Missing Docstrings...........................................Failed
- hook id: invoke
- duration: 1.49s
- exit code: 1

The function 'nesthash' on 'salt/modules/virt.py' does not have a 'CLI Example:' in it's docstring
The function 'init' on 'salt/modules/virt.py' does not have a 'CLI Example:' in it's docstring
The function 'node_devices' on 'salt/modules/virt.py' does not have a 'CLI Example:' in it's docstring
The function 'network_update' on 'salt/modules/virt.py' does not have a 'CLI Example:' in it's docstring
The function 'pool_update' on 'salt/modules/virt.py' does not have a 'CLI Example:' in it's docstring
Found 5 errors


Thanks again!

@Ch3LL Ch3LL added the Phosphorus v3005.0 Release code name and version label Feb 24, 2022
@Ch3LL Ch3LL merged commit 442e122 into saltstack:master Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Phosphorus v3005.0 Release code name and version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove old args in salt/modules/virt.py

2 participants