Allow for minion failure to respond to job sent in batch mode #61728
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows for failed in data when handling batch mode responses from client, see
salt/salt/client/__init__.py
Lines 1362 to 1374 in f65f953
What issues does this PR fix or reference?
Fixes: #60724
Previous Behavior
In a large environment with 1000s for minions connected to a Master, some commands where causing tracebacks due to key 'ret' not found in data dictionary when processing response to jobs sent.
New Behavior
Now checks for '{"failed": True}' being returned when processing responses to jobs sent in batch mode.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.