Ensure config module loads opts from the named_context. #61732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from the named_context.
|
run full-all |
|
re-run full all |
…oxy controlled proxy minions that the correct values are returned
garethgreenaway
changed the title
dwoz
requested changes
Mar 8, 2022
dwoz
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ensure opts is included in pack for minion_mods and config loads opts from the named_context.
What issues does this PR fix or reference?
Fixes: #61297
Previous Behavior
When used with deltaproxy, the config module would use the
__opts__from the last sub proxy minion that used theconfigmodule during initialization as part of configuring beacons. This would result in incorrect values being returned by theconfigmodule.New Behavior
Load
__opts__from the Salt loader's named_context to ensure we're using the__opts__for the correct minion.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.