#60700 Autostart option for virt module

[XelK]

What does this PR do?

#60700 add autostart option to virt module. Implemented in virt.running and virt.defined

What issues does this PR fix or reference?

[FEATURE REQUEST] salt.states.virt: support autostart for VMs #60700

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

• Docs
• Changelog - https://docs.saltproject.io/en/master/topics/development/changelog.html
• Tests written/updated
  Automatic tests passed

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

[welcome]

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

• Community Wiki
• Salt’s Contributor Guide
• Join our Community Slack
• IRC on LiberaChat
• Salt Project YouTube channel
• Salt Project Twitch channel

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

[XelK]

Hi! I'm your friendly PR bot!

You might be wondering what I'm doing commenting here on your PR.

Yes, as a matter of fact, I am...

I'm just here to help us improve the documentation. I can't respond to questions or anything, but what I can do, I do well!

Okay... so what do you do?

I detect modules that are missing docstrings or "CLI Example" on existing docstrings! When I was created we had a lot of these. The documentation for these modules need some love and attention to make Salt better for our users.

So what does that have to do with my PR?

I noticed that in this PR there are some files changed that have some of these issues. So I'm leaving this comment to let you know your options.

Okay, what are they?

Well, my favorite, is that since you were making changes here I'm hoping that you would be the most familiar with this module and be able to add some other examples or fix any of the reported issues.

If I can, then what?

Well, you can either add them to this PR or add them to another PR. Either way is fine!

Well... what if I can't, or don't want to?

That's also fine! We appreciate all contributions to the Salt Project. If you can't add those other examples, either because you're too busy, or unfamiliar, or you just aren't interested, we still appreciate the contributions that you've made already.

Whatever approach you decide to take, just drop a comment here letting us know!
Detected Issues (click me)

Thanks again!

Functions with the issues were not updated with this pr.

[cbosdo]

Could you please adapt the unit tests to add the new parameter? You can see the errors by clicking the red tests in this PR. This opens a page with a View more details on ... link to the report at the bottom.

[MKLeb]

Hi @XelK, it looks like there are some related failing virt tests here. Also, would you mind adding some additional tests to test this specific addition and a changelog?

[MKLeb]

@cbosdo I have updated the tests and added a new one for the update func if you wanted to take a quick look and re-review

[cbosdo]

Thanks a lot for the PR and the tests adjustments 👍🏻

[github-actions]

Hi! I'm your friendly PR bot!

You might be wondering what I'm doing commenting here on your PR.

Yes, as a matter of fact, I am...

I'm just here to help us improve the documentation. I can't respond to
questions or anything, but what I can do, I do well!

Okay... so what do you do?

I detect modules that are missing docstrings or "CLI Example" on existing docstrings!
When I was created we had a lot of these. The documentation for these
modules need some love and attention to make Salt better for our users.

So what does that have to do with my PR?

I noticed that in this PR there are some files changed that have some of these
issues. So I'm leaving this comment to let you know your options.

Okay, what are they?

Well, my favorite, is that since you were making changes here I'm hoping that
you would be the most familiar with this module and be able to add some other
examples or fix any of the reported issues.

If I can, then what?

Well, you can either add them to this PR or add them to another PR. Either way is fine!

Well... what if I can't, or don't want to?

That's also fine! We appreciate all contributions to the Salt Project. If you
can't add those other examples, either because you're too busy, or unfamiliar,
or you just aren't interested, we still appreciate the contributions that
you've made already.

Whatever approach you decide to take, just drop a comment here letting us know!

Detected Issues (click me)

Check Known Missing Docstrings...........................................Failed
- hook id: invoke
- exit code: 1
/home/runner/.cache/pre-commit/repowhzf1i29/py_env-python3/lib/python3.9/site-packages/_distutils_hack/init.py:33: UserWarning: Setuptools is replacing distutils.

warnings.warn("Setuptools is replacing distutils.")

The function 'nesthash' on 'salt/modules/virt.py' does not have a 'CLI Example:' in its docstring

The function 'init' on 'salt/modules/virt.py' does not have a 'CLI Example:' in its docstring

The function 'node_devices' on 'salt/modules/virt.py' does not have a 'CLI Example:' in its docstring

The function 'network_update' on 'salt/modules/virt.py' does not have a 'CLI Example:' in its docstring

The function 'pool_update' on 'salt/modules/virt.py' does not have a 'CLI Example:' in its docstring

Found 5 errors

---

Thanks again!

[github-actions]

Hi! I'm your friendly PR bot!

You might be wondering what I'm doing commenting here on your PR.

Yes, as a matter of fact, I am...

I'm just here to help us improve the documentation. I can't respond to
questions or anything, but what I can do, I do well!

Okay... so what do you do?

I detect modules that are missing docstrings or "CLI Example" on existing docstrings!
When I was created we had a lot of these. The documentation for these
modules need some love and attention to make Salt better for our users.

So what does that have to do with my PR?

I noticed that in this PR there are some files changed that have some of these
issues. So I'm leaving this comment to let you know your options.

Okay, what are they?

Well, my favorite, is that since you were making changes here I'm hoping that
you would be the most familiar with this module and be able to add some other
examples or fix any of the reported issues.

If I can, then what?

Well, you can either add them to this PR or add them to another PR. Either way is fine!

Well... what if I can't, or don't want to?

That's also fine! We appreciate all contributions to the Salt Project. If you
can't add those other examples, either because you're too busy, or unfamiliar,
or you just aren't interested, we still appreciate the contributions that
you've made already.

Whatever approach you decide to take, just drop a comment here letting us know!

Detected Issues (click me)

Check Known Missing Docstrings...........................................Failed
- hook id: invoke
- exit code: 1
/home/runner/.cache/pre-commit/repowhzf1i29/py_env-python3/lib/python3.9/site-packages/_distutils_hack/init.py:33: UserWarning: Setuptools is replacing distutils.

warnings.warn("Setuptools is replacing distutils.")

The function 'nesthash' on 'salt/modules/virt.py' does not have a 'CLI Example:' in its docstring

The function 'init' on 'salt/modules/virt.py' does not have a 'CLI Example:' in its docstring

The function 'node_devices' on 'salt/modules/virt.py' does not have a 'CLI Example:' in its docstring

The function 'network_update' on 'salt/modules/virt.py' does not have a 'CLI Example:' in its docstring

The function 'pool_update' on 'salt/modules/virt.py' does not have a 'CLI Example:' in its docstring

Found 5 errors

---

Thanks again!

[Ch3LL]

merging, as there were passing tests before the changelog commit.

[welcome]

Congratulations on your first PR being merged! 🎉