Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix master caching for dynamic environments #61739

Merged
merged 3 commits into from
Mar 8, 2022

Conversation

nicholasmhughes
Copy link
Collaborator

@nicholasmhughes nicholasmhughes commented Feb 28, 2022

What does this PR do?

This PR changes the file server code to use the actual salt environment name for the file listing cache file on the master. This prevents incorrect file list information to be returned to minions using dynamic environments.

What issues does this PR fix or reference?

Fixes: #61738

Previous Behavior

See issue for details.

New Behavior

The proper file listing information is returned from the cache for a particular environment.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@nicholasmhughes nicholasmhughes requested a review from a team as a code owner February 28, 2022 21:24
@nicholasmhughes nicholasmhughes requested review from dwoz and removed request for a team February 28, 2022 21:24
@nicholasmhughes
Copy link
Collaborator Author

re-run pr-arch-lts-x86_64-py3-pytest

@garethgreenaway garethgreenaway added this to the Phosphorus v3005.0 milestone Mar 3, 2022
@nicholasmhughes
Copy link
Collaborator Author

re-run pr-arch-lts-x86_64-py3-pytest

@Ch3LL Ch3LL merged commit 7e86d9e into saltstack:master Mar 8, 2022
@nicholasmhughes nicholasmhughes deleted the fix-env-roots-caching branch March 8, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] File listing in multiple dynamic environments is cached improperly on the master
5 participants