Skip to content

Add aptkey=False to use pkgrepo.managed without apt-key#61760

Merged
Ch3LL merged 15 commits into
saltstack:masterfrom
Ch3LL:rem_apt_key
Jun 9, 2022
Merged

Add aptkey=False to use pkgrepo.managed without apt-key#61760
Ch3LL merged 15 commits into
saltstack:masterfrom
Ch3LL:rem_apt_key

Conversation

@Ch3LL

@Ch3LL Ch3LL commented Mar 7, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

Allows users to not use apt-key. Apt-key is on a deprecation path right now so this PR adds the ability to use aptkey: False with the pkgrepo.managed state to not use the apt-key cli command. Also if apt-key does not exist `apt-key is not used automatically.

What issues does this PR fix or reference?

Fixes: #59785

@Ch3LL Ch3LL requested a review from a team as a code owner March 7, 2022 17:27
@Ch3LL Ch3LL requested review from garethgreenaway and removed request for a team March 7, 2022 17:27
Comment thread salt/states/pkgrepo.py Outdated
Comment thread salt/states/pkgrepo.py Outdated
@Ch3LL Ch3LL force-pushed the rem_apt_key branch 2 times, most recently from 2af18eb to 0f10935 Compare March 11, 2022 16:09
@Ch3LL Ch3LL added the Phosphorus v3005.0 Release code name and version label Apr 5, 2022
@Ch3LL Ch3LL changed the title [WIP] Add aptkey=False to use pkgrepo.managed without apt-key Add aptkey=False to use pkgrepo.managed without apt-key Apr 12, 2022
@Ch3LL

Ch3LL commented Apr 14, 2022

Copy link
Copy Markdown
Contributor Author

re-run all

twangboy
twangboy previously approved these changes May 23, 2022
MKLeb
MKLeb previously approved these changes May 31, 2022

@waynew waynew left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few questions, otherwise from just looking on my phone it looks good

Comment thread salt/states/pkgrepo.py Outdated
Comment thread salt/modules/aptpkg.py Outdated
Comment thread tests/conftest.py Outdated
@github-actions

github-actions Bot commented Jun 2, 2022

Copy link
Copy Markdown

Hi! I'm your friendly PR bot!

You might be wondering what I'm doing commenting here on your PR.

Yes, as a matter of fact, I am...

I'm just here to help us improve the documentation. I can't respond to
questions or anything, but what I can do, I do well!

Okay... so what do you do?

I detect modules that are missing docstrings or "CLI Example" on existing docstrings!
When I was created we had a lot of these. The documentation for these
modules need some love and attention to make Salt better for our users.

So what does that have to do with my PR?

I noticed that in this PR there are some files changed that have some of these
issues. So I'm leaving this comment to let you know your options.

Okay, what are they?

Well, my favorite, is that since you were making changes here I'm hoping that
you would be the most familiar with this module and be able to add some other
examples or fix any of the reported issues.

If I can, then what?

Well, you can either add them to this PR or add them to another PR. Either way is fine!

Well... what if I can't, or don't want to?

That's also fine! We appreciate all contributions to the Salt Project. If you
can't add those other examples, either because you're too busy, or unfamiliar,
or you just aren't interested, we still appreciate the contributions that
you've made already.

Whatever approach you decide to take, just drop a comment here letting us know!

Detected Issues (click me)
Check Known Missing Docstrings...........................................Failed
- hook id: invoke
- duration: 1.87s
- exit code: 1

/home/runner/.cache/pre-commit/repo4z_86ibj/py_env-python3/lib/python3.9/site-packages/_distutils_hack/init.py:30: UserWarning: Setuptools is replacing distutils.
warnings.warn("Setuptools is replacing distutils.")
The function 'expand_repo_def' on 'salt/modules/aptpkg.py' does not have a 'CLI Example:' in its docstring
Found 1 errors


Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Phosphorus v3005.0 Release code name and version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] pkgrepo should follow current Debian standards

5 participants