Detect module run syntax version#61772
Merged
Ch3LL merged 3 commits intosaltstack:masterfrom Mar 22, 2022
Merged
Conversation
waynew
reviewed
Mar 9, 2022
dwoz
force-pushed
the
issue/master/58763
branch
2 times, most recently
from
ebf1711 to
3e5f13a
Compare
dwoz
changed the title
s0undt3ch
suggested changes
Mar 14, 2022
twangboy
previously approved these changes
Mar 15, 2022
Ch3LL
suggested changes
Mar 15, 2022
Contributor
Ch3LL
left a comment
Ch3LL
left a comment
There was a problem hiding this comment.
According to the module.run docs you should be able to do this:
test.ping:
module.run
When I run that with your PR I get this error:
ID: test.ping
Function: module.run
Result: False
Comment: No function provided.
Started: 13:26:24.650959
Duration: 1.005 ms
Changes:
But it passes on the head of master.
Contributor
Author
I've added a test case for this. |
Ch3LL
previously approved these changes
Mar 16, 2022
twangboy
previously approved these changes
Mar 16, 2022
dwoz
force-pushed
the
issue/master/58763
branch
from
863e59f to
876be9d
Compare
dwoz
force-pushed
the
issue/master/58763
branch
from
876be9d to
0b48d81
Compare
3 tasks
This was referenced Jul 20, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Detect which syntax (new style or old style) is being used for a
module.runstate call.What issues does this PR fix or reference?
Fixes: #58763
Previous Behavior
Users needed to opt-in to use the new style of calling
module.runand were not able to mix new and legacymodule.runcalls.New Behavior
Users no longer need to opt-in to the new style of calling
module.run. Both styles are now supported and which style being used is detected automatically.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.