Fix 57133 - bytes vs text encoding issue for sqlite sdb #61794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now sqlite sdb.get will fail for most purposes because the text values are not decoded. This exhibits that behavior (except of course for the lone byte-string parameter).
Ch3LL
previously approved these changes
Mar 16, 2022
|
The windows test failures are related to this change. |
Before it was pinned to an out of date buggy version, this should fix some errors and inconsistencies.
Ch3LL
suggested changes
Apr 5, 2022
requirements/base.txt
Outdated
| @@ -6,3 +6,4 @@ requests>=1.0.0 | |||
| distro>=1.0.1 | |||
| contextvars | |||
| psutil>=5.0.0 | |||
|
|
|||
Ch3LL
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
Fixes: #57133
Previous Behavior
When using SQLite as the sdb backend, a string would not survive a round-trip:
Oops!
New Behavior
Now when calling msg.unpackb we tell it raw=False - strings should be strings,
an bytes should be bytes. The test parameters verify that bytes still come back
as bytes, text comes back as texts, and other assorted values correctly survive
the round trip.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
- [ ] DocsCommits signed with GPG?
Yes