Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file.tidied flexibility #61824

Merged
merged 5 commits into from
Apr 11, 2022

Conversation

nicholasmhughes
Copy link
Collaborator

What does this PR do?

This PR extends file.tidied to include the following functionality:

  • Add exclusion regular expressions to allow for "all these things, but not these few" logic.
  • Allow match and exclusion regular expressions to match on the whole path instead of just the file/directory name
  • Allow file.tidied to follow links instead of treating them as items to tidy
  • Add the ability to compare the change and modified times of the file to the current date instead of just access time

What issues does this PR fix or reference?

Fixes: #61823

Previous Behavior

The function didn't do any of the things above.

New Behavior

Now it does!

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@nicholasmhughes nicholasmhughes requested a review from a team as a code owner March 21, 2022 23:03
@nicholasmhughes nicholasmhughes requested review from dwoz and removed request for a team March 21, 2022 23:03
@nicholasmhughes
Copy link
Collaborator Author

re-run pr-fedora-34-x86_64-py3-pytest

@nicholasmhughes
Copy link
Collaborator Author

re-run pr-freebsd-130-amd64-py3-pytest

@nicholasmhughes
Copy link
Collaborator Author

re-run pr-debian-9-amd64-py3-pytest

@garethgreenaway garethgreenaway added the Phosphorus v3005.0 Release code name and version label Apr 7, 2022
@dmurphy18 dmurphy18 self-requested a review April 7, 2022 17:24
@Ch3LL Ch3LL merged commit 20dfcdc into saltstack:master Apr 11, 2022
@nicholasmhughes nicholasmhughes deleted the add-file-tidied-functionality branch April 11, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Phosphorus v3005.0 Release code name and version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] file.tidied should be more flexible
4 participants