-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update salt.utils.stringutils.human_to_bytes for broader use #61833
update salt.utils.stringutils.human_to_bytes for broader use #61833
Conversation
Hi! I'm your friendly PR bot!You might be wondering what I'm doing commenting here on your PR. Yes, as a matter of fact, I am... I'm just here to help us improve the documentation. I can't respond to Okay... so what do you do? I detect modules that are missing docstrings or "CLI Example" on existing docstrings! So what does that have to do with my PR? I noticed that in this PR there are some files changed that have some of these Okay, what are they? Well, my favorite, is that since you were making changes here I'm hoping that If I can, then what? Well, you can either add them to this PR or add them to another PR. Either way is fine! Well... what if I can't, or don't want to? That's also fine! We appreciate all contributions to the Salt Project. If you Whatever approach you decide to take, just drop a comment here letting us know! Detected Issues (click me)Check Known Missing Docstrings...........................................Failed - hook id: invoke - duration: 1.14s - exit code: 1 Thanks again! |
re-run pr-ubuntu-2004-amd64-py3-tcp-pytest |
re-run pr-arch-lts-x86_64-py3-pytest |
1 similar comment
re-run pr-arch-lts-x86_64-py3-pytest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose Yottabytes is probably a reasonable place to stop for now
What does this PR do?
This PR moves the
_handle_unit
function from thevirt
module to thestringutils.human_to_bytes
utility in order to replace the narrow functionality there. It also tags the function as a Jinja filter.What issues does this PR fix or reference?
Fixes: #61831
Previous Behavior
human_to_bytes
didn't handle sizes above a petabyte, and also didn't handle units specified in more than a character (KB or KiB vs K).New Behavior
The function is now much more flexible and is exposed as a Jinja filter.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.