Enforce config types

[twangboy]

What does this PR do?

Enforces config types as specified in the VALID_OPTS dictionary.

What issues does this PR fix or reference?

Fixes: #57873

Previous Behavior

Config types were not enforced in all cases. This allowed for a config type that was supposed to be a list that was passed a string would end up with something like ['s', 't', 'r', 'i', 'n', 'g']

New Behavior

Does not allow config types where they cannot be cleanly converted to the expected type

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

• Docs
• Changelog - https://docs.saltproject.io/en/master/topics/development/changelog.html
• Tests written/updated

Commits signed with GPG?

Yes

[github-actions]

Hi! I'm your friendly PR bot!

You might be wondering what I'm doing commenting here on your PR.

Yes, as a matter of fact, I am...

I'm just here to help us improve the documentation. I can't respond to
questions or anything, but what I can do, I do well!

Okay... so what do you do?

I detect modules that are missing docstrings or "CLI Example" on existing docstrings!
When I was created we had a lot of these. The documentation for these
modules need some love and attention to make Salt better for our users.

So what does that have to do with my PR?

I noticed that in this PR there are some files changed that have some of these
issues. So I'm leaving this comment to let you know your options.

Okay, what are they?

Well, my favorite, is that since you were making changes here I'm hoping that
you would be the most familiar with this module and be able to add some other
examples or fix any of the reported issues.

If I can, then what?

Well, you can either add them to this PR or add them to another PR. Either way is fine!

Well... what if I can't, or don't want to?

That's also fine! We appreciate all contributions to the Salt Project. If you
can't add those other examples, either because you're too busy, or unfamiliar,
or you just aren't interested, we still appreciate the contributions that
you've made already.

Whatever approach you decide to take, just drop a comment here letting us know!

Detected Issues (click me)

Check Known Missing Docstrings...........................................Failed
- hook id: invoke
- duration: 1.06s
- exit code: 1
Traceback (most recent call last):

File "/home/runner/.cache/pre-commit/repodwrtm30m/py_env-python3/bin/invoke", line 8, in 

sys.exit(program.run())

File "/home/runner/.cache/pre-commit/repodwrtm30m/py_env-python3/lib/python3.9/site-packages/invoke/program.py", line 373, in run

self.parse_collection()

File "/home/runner/.cache/pre-commit/repodwrtm30m/py_env-python3/lib/python3.9/site-packages/invoke/program.py", line 465, in parse_collection

self.load_collection()

File "/home/runner/.cache/pre-commit/repodwrtm30m/py_env-python3/lib/python3.9/site-packages/invoke/program.py", line 696, in load_collection

module, parent = loader.load(coll_name)

File "/home/runner/.cache/pre-commit/repodwrtm30m/py_env-python3/lib/python3.9/site-packages/invoke/loader.py", line 76, in load

module = imp.load_module(name, fd, path, desc)

File "/opt/hostedtoolcache/Python/3.9.10/x64/lib/python3.9/imp.py", line 244, in load_module

return load_package(name, filename)

File "/opt/hostedtoolcache/Python/3.9.10/x64/lib/python3.9/imp.py", line 216, in load_package

return _load(spec)

File "", line 711, in _load

File "", line 680, in _load_unlocked

File "", line 850, in exec_module

File "", line 228, in _call_with_frames_removed

File "/home/runner/work/salt/salt/tasks/init.py", line 3, in 

from . import docs, docstrings, filemap, loader

File "/home/runner/work/salt/salt/tasks/docstrings.py", line 13, in 

from salt.loader import SALT_INTERNAL_LOADERS_PATHS

File "/home/runner/work/salt/salt/salt/loader/init.py", line 15, in 

import salt.config

File "/home/runner/work/salt/salt/salt/config/init.py", line 101, in 

_DFLT_IPC_WBUFFER = _gather_buffer_space() * 0.5

File "/home/runner/work/salt/salt/salt/config/init.py", line 89, in _gather_buffer_space

import salt.grains.core

File "/home/runner/work/salt/salt/salt/grains/core.py", line 32, in 

import salt.modules.cmdmod

File "/home/runner/work/salt/salt/salt/modules/cmdmod.py", line 31, in 

import salt.utils.templates

File "/home/runner/work/salt/salt/salt/utils/templates.py", line 20, in 

import salt.utils.jinja

File "/home/runner/work/salt/salt/salt/utils/jinja.py", line 29, in 

from jinja2 import BaseLoader, Markup, TemplateNotFound, nodes

ImportError: cannot import name 'Markup' from 'jinja2' (/home/runner/.cache/pre-commit/repodwrtm30m/py_env-python3/lib/python3.9/site-packages/jinja2/init.py)

---

Thanks again!

[waynew]

Will check the rest of this after our meeting

[waynew]

👍