Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Packages marked NoRemove #61908

Merged
merged 2 commits into from
Apr 18, 2022
Merged

Display Packages marked NoRemove #61908

merged 2 commits into from
Apr 18, 2022

Conversation

twangboy
Copy link
Contributor

@twangboy twangboy commented Apr 1, 2022

What does this PR do?

Displays packages marked NoRemove in pkg.list_pkgs so that they can be managed with Salt. They can be updated, but not removed.

What issues does this PR fix or reference?

Fixes: #56864

Previous Behavior

Packages marked NoRemove were not displayed in pkg.list_pkgs

New Behavior

Packages marked NoRemove are now displayed

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@twangboy twangboy requested a review from a team as a code owner April 1, 2022 21:58
@twangboy twangboy requested review from garethgreenaway and removed request for a team April 1, 2022 21:58
@twangboy twangboy added this to the Phosphorus v3005.0 milestone Apr 1, 2022
@twangboy twangboy added Windows Phosphorus v3005.0 Release code name and version labels Apr 1, 2022
@twangboy twangboy force-pushed the fix_56864 branch 2 times, most recently from a9a92f5 to 6b5b6a8 Compare April 11, 2022 13:44
changelog/56864.fixed Outdated Show resolved Hide resolved
@twangboy twangboy force-pushed the fix_56864 branch 2 times, most recently from dd42dcc to 597ce04 Compare April 11, 2022 23:21
@twangboy twangboy requested a review from Ch3LL April 12, 2022 15:09
@github-actions
Copy link

Hi! I'm your friendly PR bot!

You might be wondering what I'm doing commenting here on your PR.

Yes, as a matter of fact, I am...

I'm just here to help us improve the documentation. I can't respond to
questions or anything, but what I can do, I do well!

Okay... so what do you do?

I detect modules that are missing docstrings or "CLI Example" on existing docstrings!
When I was created we had a lot of these. The documentation for these
modules need some love and attention to make Salt better for our users.

So what does that have to do with my PR?

I noticed that in this PR there are some files changed that have some of these
issues. So I'm leaving this comment to let you know your options.

Okay, what are they?

Well, my favorite, is that since you were making changes here I'm hoping that
you would be the most familiar with this module and be able to add some other
examples or fix any of the reported issues.

If I can, then what?

Well, you can either add them to this PR or add them to another PR. Either way is fine!

Well... what if I can't, or don't want to?

That's also fine! We appreciate all contributions to the Salt Project. If you
can't add those other examples, either because you're too busy, or unfamiliar,
or you just aren't interested, we still appreciate the contributions that
you've made already.

Whatever approach you decide to take, just drop a comment here letting us know!

Detected Issues (click me)
Check Known Missing Docstrings...........................................Failed
- hook id: invoke
- duration: 1.4s
- exit code: 1

/home/runner/.cache/pre-commit/repo17_4m1al/py_env-python3/lib/python3.9/site-packages/_distutils_hack/init.py:30: UserWarning: Setuptools is replacing distutils.
warnings.warn("Setuptools is replacing distutils.")
The function 'get_package_info' on 'salt/modules/win_pkg.py' does not have a 'CLI Example:' in it's docstring
Found 1 errors


Thanks again!

@Ch3LL Ch3LL merged commit 08cf17c into saltstack:master Apr 18, 2022
@twangboy twangboy deleted the fix_56864 branch March 23, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Phosphorus v3005.0 Release code name and version Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] win_pkg.list_pkgs not detecting software
2 participants