ipwrap() Jinja filter #61933
Merged
ipwrap() Jinja filter #61933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it make sense to implement this as an execution function rather than a filter? Then it can be used elsewhere too. |
|
@ggiesen is this still WIP? Also, it seems like the test is failing. |
|
Since this PR was submitted, the |
Ch3LL
suggested changes
Oct 10, 2022
Co-authored-by: Megan Wilhite <mwilhite@vmware.com>
Ch3LL
approved these changes
Oct 10, 2022
twangboy
approved these changes
Oct 10, 2022
MKLeb
approved these changes
Oct 11, 2022
garethgreenaway
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
Fixes: #61931
New Behavior
Adds ipwrap() jinja filter to wrap IPv6 addresses with brackets.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.