Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parallel state run time output #62000

Merged

Conversation

garethgreenaway
Copy link
Contributor

@garethgreenaway garethgreenaway commented Apr 28, 2022

What does this PR do?

When states are running in parallel, ensure that the total run time produced by the highstate outputter takes that into account.

What issues does this PR fix or reference?

Fixes: #61999

Previous Behavior

When running states in parallel the total run time was incorrect, combining the runtime for all sates.

New Behavior

When running states in parallel, we calculate the run time for states that were not run in parallel as normal and add the duration of the longest running parallel state run.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@garethgreenaway garethgreenaway requested a review from a team as a code owner April 28, 2022 23:21
@garethgreenaway garethgreenaway requested review from waynew and removed request for a team April 28, 2022 23:21
@Ch3LL Ch3LL added the Phosphorus v3005.0 Release code name and version label May 10, 2022
@github-actions
Copy link

Hi! I'm your friendly PR bot!

You might be wondering what I'm doing commenting here on your PR.

Yes, as a matter of fact, I am...

I'm just here to help us improve the documentation. I can't respond to
questions or anything, but what I can do, I do well!

Okay... so what do you do?

I detect modules that are missing docstrings or "CLI Example" on existing docstrings!
When I was created we had a lot of these. The documentation for these
modules need some love and attention to make Salt better for our users.

So what does that have to do with my PR?

I noticed that in this PR there are some files changed that have some of these
issues. So I'm leaving this comment to let you know your options.

Okay, what are they?

Well, my favorite, is that since you were making changes here I'm hoping that
you would be the most familiar with this module and be able to add some other
examples or fix any of the reported issues.

If I can, then what?

Well, you can either add them to this PR or add them to another PR. Either way is fine!

Well... what if I can't, or don't want to?

That's also fine! We appreciate all contributions to the Salt Project. If you
can't add those other examples, either because you're too busy, or unfamiliar,
or you just aren't interested, we still appreciate the contributions that
you've made already.

Whatever approach you decide to take, just drop a comment here letting us know!

Detected Issues (click me)
Check Known Missing Docstrings...........................................Failed
- hook id: invoke
- duration: 0.98s
- exit code: 1

/home/runner/.cache/pre-commit/repo297mwl1a/py_env-python3/lib/python3.9/site-packages/_distutils_hack/init.py:30: UserWarning: Setuptools is replacing distutils.
warnings.warn("Setuptools is replacing distutils.")
The function 'assumed_creds' on 'salt/utils/aws.py' does not have a docstring
Found 1 errors


Thanks again!

@Ch3LL Ch3LL merged commit ae2c409 into saltstack:master May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Phosphorus v3005.0 Release code name and version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Highstate total runtime incorrect for parallel states
2 participants