Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing items, values, and keys functions in the data module. #62024

Merged
merged 4 commits into from
May 18, 2022

Conversation

garethgreenaway
Copy link
Contributor

@garethgreenaway garethgreenaway commented May 4, 2022

What does this PR do?

Fixing items, values, and keys functions in the data module. Moving integration to functional tests. Converting unit test over to pytest.

What issues does this PR fix or reference?

Fixes: #61812 #62024

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

…ntegration to functional tests. Converting unit test over to pytest.
@garethgreenaway garethgreenaway requested a review from a team as a code owner May 4, 2022 18:49
@garethgreenaway garethgreenaway requested review from dwoz and removed request for a team May 4, 2022 18:49
@Ch3LL Ch3LL added the Phosphorus v3005.0 Release code name and version label May 10, 2022
@Ch3LL Ch3LL merged commit 63e6a6e into saltstack:master May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Phosphorus v3005.0 Release code name and version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] data.items, data.keys and data.values do not return anything salt command data.items crashes
2 participants