Add win_shortcut execution and state modules#62025
Merged
Merged
Conversation
twangboy
force-pushed
the
win_shortcut
branch
3 times, most recently
from
b85ba6b to
0d5d838
Compare
Ch3LL
suggested changes
May 19, 2022
twangboy
force-pushed
the
win_shortcut
branch
2 times, most recently
from
f3ceb80 to
1ee588d
Compare
Ch3LL
previously approved these changes
May 24, 2022
Ch3LL
approved these changes
May 27, 2022
dwoz
approved these changes
Jun 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an execution module and a state module for working with shortcuts on Windows.
Splits out the
file.shortcutcode into it's own execution module and state moduleAdds future deprecation for the
file.shortcutstate function to be removed in ArgonAdds functional tests for the two new modules
What issues does this PR fix or reference?
Fixes: #61170
Fixes: #53706
Previous Behavior
All code for creating shortcuts resided in the
file.shortcutstate module. No execution module.New Behavior
Abstracts the execution logic from the state logic by breaking them apart. Allows for the more salty
shortcut.presentstate name for creating a new shortcut.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes