Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/ubuntu 2204 test fixes #62073

Merged
merged 5 commits into from
May 20, 2022

Conversation

MKLeb
Copy link
Contributor

@MKLeb MKLeb commented May 16, 2022

What does this PR do?

Preps the test suite for ubuntu 22.04

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@MKLeb MKLeb requested a review from a team as a code owner May 16, 2022 21:14
@MKLeb MKLeb requested review from twangboy and removed request for a team May 16, 2022 21:14
@MKLeb
Copy link
Contributor Author

MKLeb commented May 16, 2022

re-run full all

tests/unit/modules/test_pdbedit.py Outdated Show resolved Hide resolved
Co-authored-by: Pedro Algarvio <pedro@algarvio.me>
@MKLeb MKLeb requested a review from s0undt3ch May 18, 2022 16:56
@MKLeb
Copy link
Contributor Author

MKLeb commented May 19, 2022

re-run all

@github-actions
Copy link

Hi! I'm your friendly PR bot!

You might be wondering what I'm doing commenting here on your PR.

Yes, as a matter of fact, I am...

I'm just here to help us improve the documentation. I can't respond to
questions or anything, but what I can do, I do well!

Okay... so what do you do?

I detect modules that are missing docstrings or "CLI Example" on existing docstrings!
When I was created we had a lot of these. The documentation for these
modules need some love and attention to make Salt better for our users.

So what does that have to do with my PR?

I noticed that in this PR there are some files changed that have some of these
issues. So I'm leaving this comment to let you know your options.

Okay, what are they?

Well, my favorite, is that since you were making changes here I'm hoping that
you would be the most familiar with this module and be able to add some other
examples or fix any of the reported issues.

If I can, then what?

Well, you can either add them to this PR or add them to another PR. Either way is fine!

Well... what if I can't, or don't want to?

That's also fine! We appreciate all contributions to the Salt Project. If you
can't add those other examples, either because you're too busy, or unfamiliar,
or you just aren't interested, we still appreciate the contributions that
you've made already.

Whatever approach you decide to take, just drop a comment here letting us know!

Detected Issues (click me)
Check Known Missing Docstrings...........................................Failed
- hook id: invoke
- duration: 1.38s
- exit code: 1

/home/runner/.cache/pre-commit/repoqohub75y/py_env-python3/lib/python3.9/site-packages/_distutils_hack/init.py:30: UserWarning: Setuptools is replacing distutils.
warnings.warn("Setuptools is replacing distutils.")
The function 'expand_repo_def' on 'salt/modules/aptpkg.py' does not have a 'CLI Example:' in it's docstring
Found 1 errors


Thanks again!

@garethgreenaway garethgreenaway merged commit 59a144a into saltstack:master May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants