Merged
Conversation
Contributor
|
re-run all |
Contributor
|
re-run full pr-ubuntu-2204 |
Contributor
|
re-run full pr-ubuntu-2204 |
Contributor
|
re-run full pr-ubuntu-2204 |
Ch3LL
suggested changes
Jun 3, 2022
| # pip-compile --output-file=requirements/static/ci/py3.10/linux-crypto.txt --pip-args='--constraint=requirements/static/ci/py3.10/linux.txt' requirements/static/ci/crypto.in | ||
| # | ||
| m2crypto==0.35.2 | ||
| m2crypto==0.38.0 |
Contributor
There was a problem hiding this comment.
why are you only updating m2crypto for python 3.10?
Contributor
There was a problem hiding this comment.
0.35.2 fails to build on python 3.10, switching to 0.38.0 solves that problem
Contributor
There was a problem hiding this comment.
Why not upgrade m2crypto for all python versions?
Contributor
There was a problem hiding this comment.
Done, will adjust parameters if/when failures arise.
Contributor
There was a problem hiding this comment.
Can confirm m2crypto==0.38.0 installs on python 3.5-3.10
Contributor
|
re-run full pr-ubuntu-2204 |
Contributor
|
re-run full pr-ubuntu-2204 |
Ch3LL
reviewed
Jun 7, 2022
Contributor
Contributor
|
re-run full all |
Ch3LL
approved these changes
Jun 13, 2022
garethgreenaway
approved these changes
Jun 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add Ubuntu 22.04
Fixes: #61995 #61779