Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ubuntu 22.04 #62100

Merged
merged 12 commits into from
Jun 14, 2022
Merged

Add Ubuntu 22.04 #62100

merged 12 commits into from
Jun 14, 2022

Conversation

krionbsd
Copy link
Contributor

@krionbsd krionbsd commented May 24, 2022

What does this PR do?

Add Ubuntu 22.04

Fixes: #61995 #61779

@krionbsd krionbsd requested a review from a team as a code owner May 24, 2022 17:46
@krionbsd krionbsd requested review from dwoz and removed request for a team May 24, 2022 17:46
@MKLeb
Copy link
Contributor

MKLeb commented May 25, 2022

re-run all

@MKLeb
Copy link
Contributor

MKLeb commented May 26, 2022

re-run full pr-ubuntu-2204

@MKLeb
Copy link
Contributor

MKLeb commented May 31, 2022

re-run full pr-ubuntu-2204

@MKLeb
Copy link
Contributor

MKLeb commented Jun 1, 2022

re-run full pr-ubuntu-2204

@@ -4,7 +4,7 @@
#
# pip-compile --output-file=requirements/static/ci/py3.10/linux-crypto.txt --pip-args='--constraint=requirements/static/ci/py3.10/linux.txt' requirements/static/ci/crypto.in
#
m2crypto==0.35.2
m2crypto==0.38.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you only updating m2crypto for python 3.10?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.35.2 fails to build on python 3.10, switching to 0.38.0 solves that problem

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not upgrade m2crypto for all python versions?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, will adjust parameters if/when failures arise.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm m2crypto==0.38.0 installs on python 3.5-3.10

salt/modules/x509.py Show resolved Hide resolved
@MKLeb
Copy link
Contributor

MKLeb commented Jun 3, 2022

re-run full pr-ubuntu-2204

@MKLeb
Copy link
Contributor

MKLeb commented Jun 3, 2022

re-run full pr-ubuntu-2204

@Foorack
Copy link
Contributor

Foorack commented Jun 11, 2022

Please also tag Fixes #61799 as #61995 is a duplicate of that issue.

@MKLeb
Copy link
Contributor

MKLeb commented Jun 13, 2022

re-run full all

@garethgreenaway garethgreenaway merged commit 571e62a into saltstack:master Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Ubuntu 22.04 to CI
6 participants