Fix file.comment state picks up comments after config in line#62122
Merged
Conversation
…ig in the line
nicholasmhughes
force-pushed
the
fix-file-comment-62121
branch
from
May 31, 2022 10:43
a20174c to
a121693
Compare
nicholasmhughes
force-pushed
the
fix-file-comment-62121
branch
from
May 31, 2022 10:43
a121693 to
c348e82
Compare
Contributor
Author
|
re-run pr-freebsd-131-amd64-py3-pytest |
Ch3LL
approved these changes
May 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See issue referenced below and comment in #62045 for details.
What issues does this PR fix or reference?
Fixes: #62121
Previous Behavior
Uncommented lines with a comment later in the line would not be commented as expected.
New Behavior
Comments are inserted as expected when the line has a later comment after the config.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.