Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change signedby default directory to /etc/apt/keyrings #62159

Merged
merged 6 commits into from
Jun 18, 2022

Conversation

Ch3LL
Copy link
Contributor

@Ch3LL Ch3LL commented Jun 13, 2022

Follow up to #61760 which is not in a released version so it does not require a changelog file.

This PR resolves the comments here: #59785 (comment)

@Ch3LL Ch3LL requested a review from a team as a code owner June 13, 2022 17:56
@Ch3LL Ch3LL requested review from whytewolf and removed request for a team June 13, 2022 17:56
@Ch3LL Ch3LL added the Phosphorus v3005.0 Release code name and version label Jun 13, 2022
@Ch3LL Ch3LL force-pushed the sign_default branch 3 times, most recently from 18df842 to 672d503 Compare June 14, 2022 15:25
MKLeb
MKLeb previously approved these changes Jun 15, 2022
@Ch3LL
Copy link
Contributor Author

Ch3LL commented Jun 16, 2022

re-run full all

@Ch3LL
Copy link
Contributor Author

Ch3LL commented Jun 16, 2022

re-run full all

garethgreenaway and others added 3 commits June 16, 2022 17:23
Change another PosixPath for a string for Debian 9.
One more PoxixPath that needs to be a string.
@Ch3LL
Copy link
Contributor Author

Ch3LL commented Jun 17, 2022

re-run full all

@github-actions
Copy link

Hi! I'm your friendly PR bot!

You might be wondering what I'm doing commenting here on your PR.

Yes, as a matter of fact, I am...

I'm just here to help us improve the documentation. I can't respond to
questions or anything, but what I can do, I do well!

Okay... so what do you do?

I detect modules that are missing docstrings or "CLI Example" on existing docstrings!
When I was created we had a lot of these. The documentation for these
modules need some love and attention to make Salt better for our users.

So what does that have to do with my PR?

I noticed that in this PR there are some files changed that have some of these
issues. So I'm leaving this comment to let you know your options.

Okay, what are they?

Well, my favorite, is that since you were making changes here I'm hoping that
you would be the most familiar with this module and be able to add some other
examples or fix any of the reported issues.

If I can, then what?

Well, you can either add them to this PR or add them to another PR. Either way is fine!

Well... what if I can't, or don't want to?

That's also fine! We appreciate all contributions to the Salt Project. If you
can't add those other examples, either because you're too busy, or unfamiliar,
or you just aren't interested, we still appreciate the contributions that
you've made already.

Whatever approach you decide to take, just drop a comment here letting us know!

Detected Issues (click me)
Check Known Missing Docstrings...........................................Failed
- hook id: invoke
- duration: 1.45s
- exit code: 1

/home/runner/.cache/pre-commit/repoj_ywqv3d/py_env-python3/lib/python3.9/site-packages/_distutils_hack/init.py:30: UserWarning: Setuptools is replacing distutils.
warnings.warn("Setuptools is replacing distutils.")
The function 'expand_repo_def' on 'salt/modules/aptpkg.py' does not have a 'CLI Example:' in its docstring
Found 1 errors


Thanks again!

@garethgreenaway garethgreenaway merged commit cf5a19b into saltstack:master Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Phosphorus v3005.0 Release code name and version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants