Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modules/aptpkg): fix recent regressions introduced in salt.modules.aptpkg #62177

Conversation

myii
Copy link
Contributor

@myii myii commented Jun 16, 2022

What does this PR do?

Resolve recent regressions in salt.modules.aptpkg, encountered when using the pkgrepo.managed state.

CC: @Ch3LL.

What issues does this PR fix or reference?

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@myii myii requested a review from a team as a code owner June 16, 2022 08:49
@myii myii requested review from krionbsd and removed request for a team June 16, 2022 08:49
@Ch3LL Ch3LL force-pushed the bug/fix-regressions-introduced-in-salt.modules.aptpkg branch from 7aab8ec to d49e744 Compare June 23, 2022 15:34
@Ch3LL
Copy link
Contributor

Ch3LL commented Jun 23, 2022

Note for reviewers: this does not require a changelog since the new signedby code has never made it to a release.

@Ch3LL
Copy link
Contributor

Ch3LL commented Jun 23, 2022

re-run full all

@Ch3LL Ch3LL force-pushed the bug/fix-regressions-introduced-in-salt.modules.aptpkg branch from d49e744 to 9aedf6b Compare June 24, 2022 13:30
@Ch3LL
Copy link
Contributor

Ch3LL commented Jun 24, 2022

re-run full all

@github-actions
Copy link

Hi! I'm your friendly PR bot!

You might be wondering what I'm doing commenting here on your PR.

Yes, as a matter of fact, I am...

I'm just here to help us improve the documentation. I can't respond to
questions or anything, but what I can do, I do well!

Okay... so what do you do?

I detect modules that are missing docstrings or "CLI Example" on existing docstrings!
When I was created we had a lot of these. The documentation for these
modules need some love and attention to make Salt better for our users.

So what does that have to do with my PR?

I noticed that in this PR there are some files changed that have some of these
issues. So I'm leaving this comment to let you know your options.

Okay, what are they?

Well, my favorite, is that since you were making changes here I'm hoping that
you would be the most familiar with this module and be able to add some other
examples or fix any of the reported issues.

If I can, then what?

Well, you can either add them to this PR or add them to another PR. Either way is fine!

Well... what if I can't, or don't want to?

That's also fine! We appreciate all contributions to the Salt Project. If you
can't add those other examples, either because you're too busy, or unfamiliar,
or you just aren't interested, we still appreciate the contributions that
you've made already.

Whatever approach you decide to take, just drop a comment here letting us know!

Detected Issues (click me)
Check Known Missing Docstrings...........................................Failed
- hook id: invoke
- duration: 1.05s
- exit code: 1

/home/runner/.cache/pre-commit/reporaptzk2i/py_env-python3/lib/python3.9/site-packages/_distutils_hack/init.py:30: UserWarning: Setuptools is replacing distutils.
warnings.warn("Setuptools is replacing distutils.")
The function 'expand_repo_def' on 'salt/modules/aptpkg.py' does not have a 'CLI Example:' in its docstring
Found 1 errors


Thanks again!

@Ch3LL Ch3LL merged commit 058379e into saltstack:master Jun 27, 2022
@myii myii deleted the bug/fix-regressions-introduced-in-salt.modules.aptpkg branch June 27, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants