-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(modules/aptpkg): fix recent regressions introduced in salt.modules.aptpkg #62177
fix(modules/aptpkg): fix recent regressions introduced in salt.modules.aptpkg #62177
Conversation
7aab8ec
to
d49e744
Compare
Note for reviewers: this does not require a changelog since the new signedby code has never made it to a release. |
re-run full all |
Regression introduced in 409072c (saltstack#61760). Fixes saltstack#62175.
Regression introduced in b42487f (saltstack#61760). Fixes saltstack#62176.
d49e744
to
9aedf6b
Compare
re-run full all |
Hi! I'm your friendly PR bot!You might be wondering what I'm doing commenting here on your PR. Yes, as a matter of fact, I am... I'm just here to help us improve the documentation. I can't respond to Okay... so what do you do? I detect modules that are missing docstrings or "CLI Example" on existing docstrings! So what does that have to do with my PR? I noticed that in this PR there are some files changed that have some of these Okay, what are they? Well, my favorite, is that since you were making changes here I'm hoping that If I can, then what? Well, you can either add them to this PR or add them to another PR. Either way is fine! Well... what if I can't, or don't want to? That's also fine! We appreciate all contributions to the Salt Project. If you Whatever approach you decide to take, just drop a comment here letting us know! Detected Issues (click me)Check Known Missing Docstrings...........................................Failed - hook id: invoke - duration: 1.05s - exit code: 1 Thanks again! |
What does this PR do?
Resolve recent regressions in
salt.modules.aptpkg
, encountered when using thepkgrepo.managed
state.CC: @Ch3LL.
What issues does this PR fix or reference?
aptpkg
: Failed to configure repo ...': 'str' object has no attribute 'name' #62175aptpkg
: Traceback: KeyError: 'index' #62176Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes