Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix yamllint config failure on older versions. #62243

Merged
merged 2 commits into from
Jun 30, 2022
Merged

Conversation

whytewolf
Copy link
Collaborator

What does this PR do?

  • adds version comp stuff so older versions of yamllint don't break.
  • removes utils call and changes to import
  • adds version information to utils module.
  • checks version in module.

What issues does this PR fix or reference?

Fixes: #62238

Previous Behavior

packaged yamllint from ubuntu 20.04 caused issues.

New Behavior

yamllint 1.20.0 and above don't cause issues and should work just fine.

Merge requirements satisfied?

Commits signed with GPG?

No

Thomas Phipps added 2 commits June 29, 2022 20:30
* removes __utils__ call and utalizes import instead.
* adds tests for new function and changes to __virtual__
@whytewolf whytewolf requested a review from a team as a code owner June 29, 2022 20:51
@whytewolf whytewolf requested review from krionbsd and removed request for a team June 29, 2022 20:51
@Ch3LL Ch3LL merged commit 0942ad3 into saltstack:master Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] yaml.lint fails with yamllint.config.YamlLintConfigError
3 participants