-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix use of random shuffle and sample functions as Jinja filters #62373
Conversation
…ns as Jinja filters
@Ch3LL , will this get back-ported to master or do I need to get another PR in? |
re-run pr-centosstream-9-x86_64-py3-pytest |
hey @nicholasmhughes we would rather not push more includes as a work around. if the functions are only meant as jinja filters they should be added/moved to salt/utils/jinja.py. Also thank you for all the PR's you have been submitting. |
@whytewolf , near as I can tell this is the intended operation for including the decorator and not a workaround. As an example, the |
@nicholasmhughes I would be much more comfortable if the item being included in the render state wasn't coming from the modules. there are a couple of minor exceptions. modules that existed before utils was a thing like cmdmod and selinux. but overall importing from modules into utils is bad. Also. from the original discussion about the decorator it isn't working as expected. it shouldn't need to be imported directly if it was working right. |
What does this PR do?
See issue for details
What issues does this PR fix or reference?
Fixes: #62372
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.