Deprecate Django returner#62644
Merged
garethgreenaway merged 2 commits intoOct 31, 2022
Merged
Conversation
It's likely that the Django returner never worked - it can only fire signals from within the same process that the Django server is running in, which *won't* be the process that Salt is running in. Deprecating and marking for removal.
Ch3LL
reviewed
Sep 19, 2022
Contributor
Ch3LL
left a comment
Ch3LL
left a comment
There was a problem hiding this comment.
Why are we removing the returner and not fixing it or moving to a salt extension?
Contributor
|
bump @waynew did you see my comments above? |
twangboy
approved these changes
Oct 31, 2022
whytewolf
approved these changes
Oct 31, 2022
MKLeb
approved these changes
Oct 31, 2022
garethgreenaway
approved these changes
Oct 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Deprecates the Django module so we can remove it. TBH we could probably just go
ahead and remove it.
It's likely that the Django returner never worked - it can only fire
signals from within the same process that the Django server is running
in, which won't be the process that Salt is running in. Deprecating
and marking for removal.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.