pillar: netbox: create "connected_devices" function#62666
Merged
Conversation
ITJamie
requested review from
garethgreenaway
and removed request for
a team
September 12, 2022 20:39
ITJamie
changed the title
Ch3LL
suggested changes
Sep 20, 2022
garethgreenaway
added
needs-testcase
Contributor
Author
|
working on tests now. I will be updating most of the test data examples since they are from an older netbox api version. |
ITJamie
requested review from
Ch3LL
and removed request for
garethgreenaway
September 27, 2022 16:28
Ch3LL
approved these changes
Sep 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
add a dictionary of connected devices to netbox ext_pillar
What issues does this PR fix or reference?
Fixes:
#62761
Previous Behavior
New Behavior
add a dictionary of connected devices to netbox ext_pillar
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.