Add more file.tidied decision logic #62679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasmhughes
requested review from
ScriptAutomate
and removed request for
a team
|
re-run pr-debian-11-amd64-py3-pytest |
|
re-run pr-macosx-catalina-x86_64-py3-pytest |
ScriptAutomate
requested review from
a team and
garethgreenaway
and removed request for
ScriptAutomate and
a team
Ch3LL
approved these changes
Sep 20, 2022
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the
age_size_logical_operatorandage_size_onlyparameters tofile.tidied, which allow additional flexibility in specifying age and size conditions which trigger removal of files.What issues does this PR fix or reference?
Fixes: #62678
Previous Behavior
The
file.tidiedstate did not support "AND" logic forageandsizeparameters, nor did it allow for only one of those parameters to be used in the determination for removal.New Behavior
The new parameters now allow for better usability of the state.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.