Skip to content

Add more file.tidied decision logic#62679

Merged
Ch3LL merged 2 commits into
saltstack:masterfrom
nicholasmhughes:add-more-file.tidied-decision-logic
Sep 20, 2022
Merged

Add more file.tidied decision logic#62679
Ch3LL merged 2 commits into
saltstack:masterfrom
nicholasmhughes:add-more-file.tidied-decision-logic

Conversation

@nicholasmhughes

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR adds the age_size_logical_operator and age_size_only parameters to file.tidied, which allow additional flexibility in specifying age and size conditions which trigger removal of files.

What issues does this PR fix or reference?

Fixes: #62678

Previous Behavior

The file.tidied state did not support "AND" logic for age and size parameters, nor did it allow for only one of those parameters to be used in the determination for removal.

New Behavior

The new parameters now allow for better usability of the state.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@nicholasmhughes nicholasmhughes requested a review from a team as a code owner September 13, 2022 20:18
@nicholasmhughes nicholasmhughes requested review from ScriptAutomate and removed request for a team September 13, 2022 20:18
@nicholasmhughes nicholasmhughes added the Sulfur v3006.0 release code name and version label Sep 13, 2022
@nicholasmhughes

Copy link
Copy Markdown
Contributor Author

re-run pr-debian-11-amd64-py3-pytest

@nicholasmhughes

Copy link
Copy Markdown
Contributor Author

re-run pr-macosx-catalina-x86_64-py3-pytest

@ScriptAutomate ScriptAutomate requested review from a team and garethgreenaway and removed request for a team and ScriptAutomate September 15, 2022 21:27
@Ch3LL Ch3LL merged commit bbe4cab into saltstack:master Sep 20, 2022
@nicholasmhughes nicholasmhughes deleted the add-more-file.tidied-decision-logic branch September 20, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Sulfur v3006.0 release code name and version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] increase file.tidied flexibility with regard to age and size

2 participants