Skip to content

Run sync_roster when saltutil.sync_all is called #62805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

garethgreenaway
Copy link
Contributor

@garethgreenaway garethgreenaway commented Oct 3, 2022

What does this PR do?

When saltutil.sync_all is called also call sync_roster. Adding some very basic unit tests.

What issues does this PR fix or reference?

Fixes: #53914

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@garethgreenaway garethgreenaway requested a review from a team as a code owner October 3, 2022 23:32
@garethgreenaway garethgreenaway requested review from Ch3LL and removed request for a team October 3, 2022 23:32
@garethgreenaway garethgreenaway changed the title [WIP] Run sync_roster when saltutil.sync_all is called Run sync_roster when saltutil.sync_all is called Oct 4, 2022
Ch3LL
Ch3LL previously approved these changes Oct 4, 2022
@Ch3LL Ch3LL added the Sulfur v3006.0 release code name and version label Oct 4, 2022
Ch3LL
Ch3LL previously approved these changes Oct 4, 2022
@Ch3LL Ch3LL merged commit d404153 into saltstack:master Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sulfur v3006.0 release code name and version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

salt-run saltutil.sync_all doesn't sync roster modules
2 participants