Fix Salt Syndic return events missing fun_args#62809
Merged
Merged
Conversation
keslerm
force-pushed
the
fix-fun_args-syndic
branch
from
2fa134d to
aa0dc76
Compare
Contributor
|
Hi @keslerm and thanks for your contribution. This will need some tests in order to get merged, and if you need help with that or a direction to go in then I will be glad to help. |
MKLeb
added
needs-testcase
Contributor
|
@keslerm Any updates here? |
Contributor
Author
Contributor
keslerm
force-pushed
the
fix-fun_args-syndic
branch
from
aa0dc76 to
a565802
Compare
Contributor
|
@keslerm, any luck at writing tests for this? I can help if needed! |
This fixes issue saltstack#45823 which is the fun_args value missing from the Salt Syndic returns.
keslerm
force-pushed
the
fix-fun_args-syndic
branch
from
a565802 to
e1f4863
Compare
Contributor
Author
|
@MKLeb Took a first stab at a test |
Contributor
Author
Contributor
|
re-run pr-amazon-2-x86_64-py3-pytest |
MKLeb
approved these changes
Nov 7, 2022
garethgreenaway
approved these changes
Nov 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #45823 which is the fun_args value missing from the Salt Syndic returns.
What does this PR do?
This includes the fun_args value from the Syndic return. Currently this is missing resulting in the fun_args value being null.
What issues does this PR fix or reference?
Fixes: #45823
Previous Behavior
fun_args is null in the return
New Behavior
fun_args is populated with the correct values
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.