-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Fix Salt Syndic return events missing fun_args #62809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2fa134d
to
aa0dc76
Compare
Hi @keslerm and thanks for your contribution. This will need some tests in order to get merged, and if you need help with that or a direction to go in then I will be glad to help. |
@keslerm Any updates here? |
aa0dc76
to
a565802
Compare
@keslerm, any luck at writing tests for this? I can help if needed! |
This fixes issue saltstack#45823 which is the fun_args value missing from the Salt Syndic returns.
a565802
to
e1f4863
Compare
@MKLeb Took a first stab at a test |
re-run pr-amazon-2-x86_64-py3-pytest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This fixes issue #45823 which is the fun_args value missing from the Salt Syndic returns.
What does this PR do?
This includes the fun_args value from the Syndic return. Currently this is missing resulting in the fun_args value being null.
What issues does this PR fix or reference?
Fixes: #45823
Previous Behavior
fun_args is null in the return
New Behavior
fun_args is populated with the correct values
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.