gpg.export_key add output and bare functionality - #62979
Merged
Merged
Conversation
A passphrase is needed to export an encrypted gpg private key A passphase is not need to export a public key The tests have been updated to reflect that fact. One test was removed as it was attempting to export a private key without pillar (but it was in fact using pillar to do that)
Contributor
Author
|
Note:
|
Contributor
Author
|
Update: |
Contributor
|
is this ready for review? |
Contributor
Author
|
Yes, could you please review it and let me know what you think? |
Ch3LL
suggested changes
Nov 8, 2022
Contributor
Author
|
@Ch3LL Ok I just pushed the requested changes except for the file write one. Could you please review my comment on that when you can? |
Ch3LL
approved these changes
Nov 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds
outputandbarefunctionality to theexport_keygpg functionWhat issues does this PR fix or reference?
Fixes: #62978
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes