Make salt-ssh respect --wipe again#63037
Merged
Merged
Conversation
MKLeb
approved these changes
Nov 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ensures the opts dict value
ssh_wipepassed to wrapped functions is in sync with the current client configuration. This fixes the--wipeCLI option and avoids some cluttering by--rand-thin-dir.What issues does this PR fix or reference?
Fixes: #61083
Previous Behavior
Thin dir is left behind, regardless of
--wipe.New Behavior
If requested, the thin dir is wiped (since 8a414d5 only for some wrapped modules, namely
cpandstate– this should probably be documented).Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes