Fix (pillar|grains).filter_by
with salt-ssh
#63041
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
pillar.filter_by
to the salt-ssh wrapper, which makes it work as expected while using salt-ssh (see linked issue)grains.filter_by
salt-ssh wrapper (tried but failed to reproduce grains.filter_by does not use default parameter when using salt-ssh #46948 / Nested grains.filter_by calls fail when using salt-ssh #50247)grains.filter_by
salt-ssh wrapper with the current execution module function, which makes use of the utility module. This might fix the above issues, if they are still relevant.What issues does this PR fix or reference?
Fixes: #56093
Previous Behavior
pillar.filter_by
always defaults to the default key using salt-sshgrains.filter_by
does not support nested grains and does not deepcopy the merging dictNew Behavior
pillar.filter_by
works as usualgrains.filter_by
works as usualMerge requirements satisfied?
Commits signed with GPG?
Yes