sysutils/py-salt: fix the efi grain on FreeBSD #63052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twangboy
requested changes
Nov 14, 2022
twangboy
added
Needs-Testcase
I can add a changelog entry. But as for tests, there is literally nothing that this function would do except return the value of our mock function. In other words, there's no way to write a test for this function that's different from simply writing the function itself. That's why one-liners usually don't need to be unit-tested. |
The logic to detect whether we booted from EFI only worked on Linux and Apple, AFAICT.
|
@asomers Please add a changelog file. |
dwoz
removed
the
Needs-Testcase
dwoz
previously approved these changes
Dec 11, 2023
dwoz
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic to detect whether we booted from EFI only worked on Linux and Apple, AFAICT.
What does this PR do?
Correctly detects EFI on FreeBSD
What issues does this PR fix or reference?
Fixes:
Previous Behavior
grains.get efi would always return False on FreeBSD
New Behavior
grains.get efi will return the correct value on FreeBSD
Merge requirements satisfied?
Commits signed with GPG?
Yes