Restore old Slack engine, add dreprecation, rename new Slack engine#63095
Merged
Ch3LL merged 4 commits intosaltstack:masterfrom Dec 7, 2022
Merged
Restore old Slack engine, add dreprecation, rename new Slack engine#63095Ch3LL merged 4 commits intosaltstack:masterfrom
Ch3LL merged 4 commits intosaltstack:masterfrom
Conversation
Ch3LL
suggested changes
Nov 21, 2022
Contributor
|
I'm also not seeing slack_bolt in our tests requirements so I'm guesing the tests are getting skipped |
Contributor
Author
|
@Ch3LL The tests will only run if the two Slack Python libraries are installed, the newer one we can install but the older one has difficulties with newer versions of Python. |
twangboy
requested changes
Nov 22, 2022
twangboy
requested changes
Nov 22, 2022
Contributor
twangboy
left a comment
twangboy
left a comment
There was a problem hiding this comment.
Need to standardize on the type/parameter for all the arguments in the docs for the functions. You're doing it on some and not others.
…e slack engine to slack_bolt until deprecation
garethgreenaway
force-pushed
the
deprecate_old_slack_engine
branch
from
9dbbd18 to
5aa16c6
Compare
Ch3LL
approved these changes
Dec 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Restore the previous slack engine and deprecate it, rename replace the slack engine to slack_bolt until deprecation
What issues does this PR fix or reference?
Fixes: #62957
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.