Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boardname grain #63132

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Conversation

nicholasmhughes
Copy link
Collaborator

What does this PR do?

See issue for details.

What issues does this PR fix or reference?

Fixes: #63131

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@nicholasmhughes nicholasmhughes requested a review from a team as a code owner November 28, 2022 22:25
@nicholasmhughes nicholasmhughes requested review from Ch3LL and removed request for a team November 28, 2022 22:25
@nicholasmhughes nicholasmhughes added the Sulfur v3006.0 release code name and version label Nov 28, 2022
@nicholasmhughes
Copy link
Collaborator Author

re-run pr-centos-7-x86_64-py3-pytest

@nicholasmhughes
Copy link
Collaborator Author

re-run pr-ubuntu-2204-amd64-py3-pytest

@nicholasmhughes
Copy link
Collaborator Author

re-run pr-ubuntu-2004-amd64-py3-pytest

@lukasraska
Copy link
Contributor

@nicholasmhughes what about other operating systems / architectures? Seems like the information can be retrieved from dmidecode as well, for Windows I assume https://learn.microsoft.com/en-us/windows/win32/cimwin32prov/win32-baseboard might be the correct WMI class.

For DeviceTree, the most reasonable field is model, but it's already being used for productname (https://github.com/saltstack/salt/blob/master/salt/grains/core.py#L1656 , this is for example value of model on RPi - Raspberry Pi 4 Model B Rev 1.1 ), so that could be just ignored I guess.

@twangboy twangboy added this to the Sulphur v3006.0 milestone Nov 29, 2022
@Ch3LL
Copy link
Contributor

Ch3LL commented Dec 2, 2022

@nicholasmhughes any thoughts on @lukasraska 's comment?

@nicholasmhughes
Copy link
Collaborator Author

I don't have a use case for other operating systems and I don't have any way to test them. I'd prefer to contribute this piece and allow the community to expand on it as the need arises.

@Ch3LL Ch3LL merged commit 07b5980 into saltstack:master Dec 5, 2022
@nicholasmhughes nicholasmhughes deleted the add-boardname-grain branch December 5, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sulfur v3006.0 release code name and version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] add boardname grain
4 participants